linux-kernel - Re: [PATCH v10 6/6] arm64: kgdb: Implement kgdb_roundup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Aug 2023 16:50:02 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Catalin Marinas <catalin.marinas@....com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Douglas Anderson <dianders@...omium.org>,
        Marc Zyngier <maz@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Sumit Garg <sumit.garg@...aro.org>,
        Will Deacon <will@...nel.org>
Cc:     Lecopzer Chen <lecopzer.chen@...iatek.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-perf-users@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        kgdb-bugreport@...ts.sourceforge.net, ito-yuichi@...itsu.com,
        Thomas Gleixner <tglx@...utronix.de>,
        Chen-Yu Tsai <wens@...e.org>, Ard Biesheuvel <ardb@...nel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Masayoshi Mizuma <msys.mizuma@...il.com>,
        D Scott Phillips <scott@...amperecomputing.com>,
        Josh Poimboeuf <jpoimboe@...nel.org>,
        Valentin Schneider <vschneid@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 6/6] arm64: kgdb: Implement kgdb_roundup_cpus() to
 enable pseudo-NMI roundup

Quoting Douglas Anderson (2023-08-22 14:27:01)
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index c51d54019f5f..5ee6b69b4360 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -75,10 +76,11 @@ enum ipi_msg_type {
>         IPI_IRQ_WORK,
>         NR_IPI,
>         /*
> -        * CPU_BACKTRACE is special and not included in NR_IPI
> +        * CPU_BACKTRACE and KGDB_ROUNDUP are special and not included in NR_IPI
>          * or tracable with trace_ipi_*

If this is going to be added to in the future then the comment could be
more generic to avoid further updates.

	 /*
	  * Any enum equal to NR_IPI or less than MAX_IPI is special and
	  * not included in NR_IPI ...
	  /