linux-kernel - Re: [PATCH 01/22] x86/srso: Fix srso_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230822052326.GAZORGTrM6N7+6l+sl@fat_crate.local>
Date:   Tue, 22 Aug 2023 07:23:26 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Josh Poimboeuf <jpoimboe@...nel.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Babu Moger <babu.moger@....com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>, David.Kaplan@....com,
        Andrew Cooper <andrew.cooper3@...rix.com>,
        Nikolay Borisov <nik.borisov@...e.com>,
        gregkh@...uxfoundation.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 01/22] x86/srso: Fix srso_show_state() side effect

On Mon, Aug 21, 2023 at 09:17:06AM -0700, Josh Poimboeuf wrote:
> I could do that, but this check ends up getting replaced by a later
> patch anyway.
> 
> Would you want this comment in srso_select_mitigation()?  After the next
> patch it has:
> 
>   bool has_microcode = boot_cpu_has(X86_FEATURE_IBPB_BRTYPE);
> 
> Though that seems clear to me already.

Ok, good enough.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette