[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ed0c0d2b-dee0-dd43-dee4-a73a46686168@linux.intel.com>
Date: Tue, 22 Aug 2023 15:42:37 +0800
From: Baolu Lu <baolu.lu@...ux.intel.com>
To: Jason Gunthorpe <jgg@...pe.ca>
Cc: baolu.lu@...ux.intel.com, Joerg Roedel <joro@...tes.org>,
Will Deacon <will@...nel.org>,
Robin Murphy <robin.murphy@....com>,
Kevin Tian <kevin.tian@...el.com>,
Jean-Philippe Brucker <jean-philippe@...aro.org>,
Nicolin Chen <nicolinc@...dia.com>,
Yi Liu <yi.l.liu@...el.com>,
Jacob Pan <jacob.jun.pan@...ux.intel.com>,
iommu@...ts.linux.dev, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 05/11] iommu: Merge iopf_device_param into
iommu_fault_param
On 2023/8/22 1:04, Jason Gunthorpe wrote:
> On Fri, Aug 18, 2023 at 07:40:41AM +0800, Lu Baolu wrote:
>> @@ -472,21 +473,31 @@ struct iommu_fault_event {
>> * struct iommu_fault_param - per-device IOMMU fault data
>> * @handler: Callback function to handle IOMMU faults at device level
>> * @data: handler private data
>> - * @faults: holds the pending faults which needs response
>> * @lock: protect pending faults list
>> + * @dev: the device that owns this param
>> + * @queue: IOPF queue
>> + * @queue_list: index into queue->devices
>> + * @partial: faults that are part of a Page Request Group for which the last
>> + * request hasn't been submitted yet.
>> + * @faults: holds the pending faults which needs response
>> */
>> struct iommu_fault_param {
>> iommu_dev_fault_handler_t handler;
>> void *data;
>> - struct list_head faults;
>> - struct mutex lock;
>> + struct mutex lock;
>> +
>> + struct device *dev;
>> + struct iopf_queue *queue;
>> + struct list_head queue_list;
>> +
>> + struct list_head partial;
>> + struct list_head faults;
>> };
> Don't add the horizontal spaces
Fixed. Thanks!
Best regards,
baolu
Powered by blists - more mailing lists