linux-kernel - Re: [PATCH AUTOSEL 6.4 18/54] thermal: core: constify params in thermal_zone_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOSRPJxpVfCiyUWb@duo.ucw.cz>
Date:   Tue, 22 Aug 2023 12:43:08 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        rafael@...nel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.4 18/54] thermal: core: constify params in
 thermal_zone_device_register

Hi!

> [ Upstream commit 80ddce5f2dbd0e83eadc9f9d373439180d599fe5 ]
> 
> Since commit 3d439b1a2ad3 ("thermal/core: Alloc-copy-free the thermal zone
> parameters structure"), thermal_zone_device_register() allocates a copy
> of the tzp argument and callers need not explicitly manage its lifetime.
> 
> This means the function no longer cares about the parameter being
> mutable, so constify it.
> 
> No functional change.

Not a bugfix, should not be in stable.

3d439b1a2ad3 ("thermal/core: Alloc-copy-free the thermal zone
parameters structure") is not in 6.1, so this is not correct patch for
6.1.

Why was this selected for AUTOSEL? Can you make sure patches marked
"No functional change." are not selected in future?

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)