linux-kernel - Re: [PATCH v2] pinctrl: cherryview: fix address_space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZOShTk4se2dWDN4X@smile.fi.intel.com>
Date:   Tue, 22 Aug 2023 14:51:42 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Raag Jadav <raag.jadav@...el.com>, linus.walleij@...aro.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        mallikarjunappa.sangannavar@...el.com, pandith.n@...el.com,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl: cherryview: fix address_space_handler()
 argument

On Tue, Aug 22, 2023 at 02:20:34PM +0300, Mika Westerberg wrote:
> On Tue, Aug 22, 2023 at 12:53:40PM +0530, Raag Jadav wrote:
> > First argument of acpi_*_address_space_handler() APIs is acpi_handle of
> > the device, which is incorrectly passed in driver ->remove() path here.
> > Fix it by passing the appropriate argument and while at it, make both
> > API calls consistent using ACPI_HANDLE().
> > 
> > Fixes: a0b028597d59 ("pinctrl: cherryview: Add support for GMMR GPIO opregion")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Raag Jadav <raag.jadav@...el.com>
> 
> Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko