linux-kernel - Re: [PATCH v2 1/1] serial: core: Remove unused PORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZOS2EOiXOn1tjKAS@smile.fi.intel.com>
Date:   Tue, 22 Aug 2023 16:20:16 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH v2 1/1] serial: core: Remove unused PORT_* definitions

On Tue, Aug 22, 2023 at 02:59:37PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 21, 2023 at 11:38:57AM +0300, Andy Shevchenko wrote:
> > For the last couple of years Linux kernel got rid of a few architectures
> > and many platforms. Hence some PORT_* definitions in the serial_core.h
> > become unused and redundant. Remove them for good.
> > 
> > Removed IDs are checked for users against Debian Code Search engine.
> > Hence safe to remove as there are no consumers found (only providers).
> > 
> > While at it, add a note about 0-13, that are defined in the other file.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> > v2: tested via DCS (Greg), dropped 1 change due to that, added a note for 0-13
> >  include/uapi/linux/serial_core.h | 43 +++-----------------------------
> >  1 file changed, 3 insertions(+), 40 deletions(-)
> 
> You forgot to cc linux-serial@...r :)

Oh, that's because I cooked this patch against v6.5-rcX, where X < 7, and hence
the 238500e2d67c ("MAINTAINERS: Merge TTY layer and serial drivers") is absent.

> I'll take this now, thanks for cleaning this up.  Hopefully we can
> resist the urge to add new ids here.

Thank you!

I want to compress the list based on DCS research, it seems feasible and may
shrink a lot of memory at run-time for the port structure. Let me check that.

-- 
With Best Regards,
Andy Shevchenko