linux-kernel - Re: [PATCH] selftests: alsa: make LDLIBS consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fd85cbe-9909-4200-be38-450d4c57425b@sirena.org.uk>
Date:   Tue, 22 Aug 2023 15:05:27 +0100
From:   Mark Brown <broonie@...nel.org>
To:     "Ricardo B. Marliere" <rbmarliere@...il.com>
Cc:     skhan@...uxfoundation.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: alsa: make LDLIBS consistent

On Tue, Aug 22, 2023 at 10:15:45AM -0300, Ricardo B. Marliere wrote:

> In kselftest_deps.sh script, the level 3 parser is broken for the alsa
> subsystem Makefile.

>  CFLAGS += $(shell pkg-config --cflags alsa)
> -LDLIBS += $(shell pkg-config --libs alsa)
> -ifeq ($(LDLIBS),)
> -LDLIBS += -lasound
> +VAR_LDLIBS += $(shell pkg-config --libs alsa)
> +ifeq ($(VAR_LDLIBS),)
> +VAR_LDLIBS += -lasound

This seems like an undocumented bodge for whatever limitation the
checker script has.  If nothing else someone might come along later and
switch back to using the standard variable name, and TBH it does feel
like it'd be better to teach the checker to understand the pkg-config
idiom here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)