linux-kernel - Re: [PATCH] watchdog: imx2_wdt: Improve dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <37f5e3d0-c841-4270-8424-7b4a8c16de7c@roeck-us.net>
Date:   Tue, 22 Aug 2023 07:08:32 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Fabio Estevam <festevam@...il.com>
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org, Fabio Estevam <festevam@...x.de>
Subject: Re: [PATCH] watchdog: imx2_wdt: Improve dev_crit() message

On Tue, Aug 22, 2023 at 10:52:55AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@...x.de>
> 
> After issuing a "poweroff" command the board goes through the
> expected power-off sequence and turns it off completely:
> 
> systemd-shutdown[1]: Powering off.
> imx2-wdt 30280000.watchdog: Device shutdown: Expect reboot!
> reboot: Power down
> 
> The "Expect reboot!" message is misleading because in the
> power-off case, no reboot is expected to happen at all.
> 
> Avoid the confusion by removing the "Expect reboot!" message.
> 
> Signed-off-by: Fabio Estevam <festevam@...x.de>

Not sure if the message should be there in the first place.
Anyway,

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/imx2_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
> index 1a27665a2f53..42e8ffae18dd 100644
> --- a/drivers/watchdog/imx2_wdt.c
> +++ b/drivers/watchdog/imx2_wdt.c
> @@ -374,7 +374,7 @@ static void imx2_wdt_shutdown(struct platform_device *pdev)
>  		 */
>  		imx2_wdt_set_timeout(wdog, IMX2_WDT_MAX_TIME);
>  		imx2_wdt_ping(wdog);
> -		dev_crit(&pdev->dev, "Device shutdown: Expect reboot!\n");
> +		dev_crit(&pdev->dev, "Device shutdown.\n");
>  	}
>  }
>  
> -- 
> 2.34.1
>