linux-kernel - Re: [PATCH v4] Currently if the SoC needs pinctrl to switch the SCL and SDA from the I2C function to GPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZOTFyHzsOSvfzNjD@smile.fi.intel.com>
Date:   Tue, 22 Aug 2023 17:27:20 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Yann Sionneau <ysionneau@...rayinc.com>
Cc:     Yann Sionneau <ysionneau@...ray.eu>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Julian Vetter <jvetter@...rayinc.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] Currently if the SoC needs pinctrl to switch the SCL
 and SDA from the I2C function to GPI

On Tue, Aug 22, 2023 at 04:15:25PM +0200, Yann Sionneau wrote:
> On 8/22/23 15:26, Andy Shevchenko wrote:
> > On Tue, Aug 22, 2023 at 03:11:23PM +0200, Yann Sionneau wrote:

...

> > You forgot my tag. Why?
> Woops sorry, I am not used to sending patches upstream. I didn't know I had
> to add the ack tag. Will do it!

Any tags, Acked-by, Reviewed-by, ...

> > Also I think this will generate more code and more noise in debug case.
> > So, I admit I gave a bad suggestion in previous round.
> Ah yes you are right in case of dbg+CONFIG_PINCTRL not set it will print
> both messages but just one is enough.
> > 
> > Please, go for v3 with my tag (as v5).
> > 
> Ok, I'll also add `i2c: designware: ` to $subject as Mika Westerberg
> suggested.

It seems that Subject was completely missing.
In the commit message it's a first line followed by a blank line.

-- 
With Best Regards,
Andy Shevchenko