linux-kernel - Re: [PATCH v1 1/1] watchdog: simatic: Use idiomatic selection of P2SB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOTQrf8VnJ8ljGK4@smile.fi.intel.com>
Date:   Tue, 22 Aug 2023 18:13:49 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v1 1/1] watchdog: simatic: Use idiomatic selection of P2SB

On Tue, Aug 22, 2023 at 04:50:14PM +0200, Hans de Goede wrote:
> On 8/22/23 16:18, Andy Shevchenko wrote:
> > While it's pretty much theoretical to be otherwise, make sure
> > that P2SB is selected only for X86. This is idiomatic dependency
> > which is used by all others who select it. Use it for Simatic
> > as well.
> 
> Hmm, this already depends on SIEMENS_SIMATIC_IPC which itself
> depends on X86, so as you already say this is not really necessary...

Yes, but I want to keep that idiom, that's it.
It's purely style change.

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Note this depends on / applies on top of 2 other
> "config SIEMENS_SIMATIC_IPC_WDT" patches which
> are currently pending in pdx86/for-next:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next
> 
> so this should probably be merged after 6.6-rc1 once
> these other changes have been merged.

Or with an Ack from watchdog maintainers... Whatever is the best for you,
folks. I'm fine with either choice.

-- 
With Best Regards,
Andy Shevchenko