linux-kernel - Re: [PATCH -next] freevxfs: Fix comment on vxfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ab538a1-45ce-5905-0ff3-c5990598e6ab@infradead.org>
Date:   Mon, 21 Aug 2023 19:53:50 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     GUO Zihua <guozihua@...wei.com>, hch@...radead.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] freevxfs: Fix comment on vxfs_readdir



On 8/21/23 18:40, GUO Zihua wrote:
> As vxfs_readdir now switches to iterate_shared interface, the parameter
> of the function is changed. However, the comment of has not been
> updated.
> 
> This patch updates function doc to reflect this change.
> 
> Fixes: 9b5d5a170781 ("[readdir] convert freevxfs")
> Signed-off-by: GUO Zihua <guozihua@...wei.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.

> ---
>  fs/freevxfs/vxfs_lookup.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/freevxfs/vxfs_lookup.c b/fs/freevxfs/vxfs_lookup.c
> index f04ba2ed1e1a..53cbb7209324 100644
> --- a/fs/freevxfs/vxfs_lookup.c
> +++ b/fs/freevxfs/vxfs_lookup.c
> @@ -177,12 +177,11 @@ vxfs_lookup(struct inode *dip, struct dentry *dp, unsigned int flags)
>  /**
>   * vxfs_readdir - read a directory
>   * @fp:		the directory to read
> - * @retp:	return buffer
> - * @filler:	filldir callback
> + * @ctx:	Dir context
>   *
>   * Description:
> - *   vxfs_readdir fills @retp with directory entries from @fp
> - *   using the VFS supplied callback @filler.
> + *   vxfs_readdir emits directory entries from @fp using the
> + *   VFS supplied @ctx.
>   *
>   * Returns:
>   *   Zero.

-- 
~Randy