linux-kernel - RE: [PATCH AUTOSEL 6.4 11/11] drm/amdkfd: disable IOMMUv2 support for Raven

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Aug 2023 15:39:30 +0000
From:   "Deucher, Alexander" <Alexander.Deucher@....com>
To:     Sasha Levin <sashal@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
CC:     "Kuehling, Felix" <Felix.Kuehling@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        Mike Lothian <mike@...eburn.co.uk>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        "airlied@...il.com" <airlied@...il.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: RE: [PATCH AUTOSEL 6.4 11/11] drm/amdkfd: disable IOMMUv2 support for
 Raven

[Public]

> -----Original Message-----
> From: Sasha Levin <sashal@...nel.org>
> Sent: Tuesday, August 22, 2023 7:36 AM
> To: linux-kernel@...r.kernel.org; stable@...r.kernel.org
> Cc: Deucher, Alexander <Alexander.Deucher@....com>; Kuehling, Felix
> <Felix.Kuehling@....com>; Koenig, Christian <Christian.Koenig@....com>;
> Mike Lothian <mike@...eburn.co.uk>; Sasha Levin <sashal@...nel.org>; Pan,
> Xinhui <Xinhui.Pan@....com>; airlied@...il.com; daniel@...ll.ch; amd-
> gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org
> Subject: [PATCH AUTOSEL 6.4 11/11] drm/amdkfd: disable IOMMUv2
> support for Raven
>
> From: Alex Deucher <alexander.deucher@....com>
>
> [ Upstream commit 091ae5473f96ced844af6ba39b94757359b12348 ]
>
> Use the dGPU path instead.  There were a lot of platform issues with IOMMU
> in general on these chips due to windows not enabling IOMMU at the time.
> The dGPU path has been used for a long time with newer APUs and works
> fine.  This also paves the way to simplify the driver significantly.

This is not needed for stable.

Alex

>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@....com>
> Acked-by: Christian König <christian.koenig@....com>
> Tested-by: Mike Lothian <mike@...eburn.co.uk>
> Signed-off-by: Alex Deucher <alexander.deucher@....com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_device.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index 9c8197573dee7..224e057d2dbbf 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -185,11 +185,6 @@ static void kfd_device_info_init(struct kfd_dev *kfd,
>
>               kfd_device_info_set_event_interrupt_class(kfd);
>
> -             /* Raven */
> -             if (gc_version == IP_VERSION(9, 1, 0) ||
> -                 gc_version == IP_VERSION(9, 2, 2))
> -                     kfd->device_info.needs_iommu_device = true;
> -
>               if (gc_version < IP_VERSION(11, 0, 0)) {
>                       /* Navi2x+, Navi1x+ */
>                       if (gc_version == IP_VERSION(10, 3, 6)) @@ -283,7
> +278,6 @@ struct kfd_dev *kgd2kfd_probe(struct amdgpu_device *adev,
> bool vf)
>                       gfx_target_version = 90000;
>                       f2g = &gfx_v9_kfd2kgd;
>                       break;
> -#ifdef KFD_SUPPORT_IOMMU_V2
>               /* Raven */
>               case IP_VERSION(9, 1, 0):
>               case IP_VERSION(9, 2, 2):
> @@ -291,7 +285,6 @@ struct kfd_dev *kgd2kfd_probe(struct
> amdgpu_device *adev, bool vf)
>                       if (!vf)
>                               f2g = &gfx_v9_kfd2kgd;
>                       break;
> -#endif
>               /* Vega12 */
>               case IP_VERSION(9, 2, 1):
>                       gfx_target_version = 90004;
> --
> 2.40.1