linux-kernel - Re: [PATCH] HID: cp2112: make the irqchip immutable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86fs49fw28.wl-maz@kernel.org>
Date:   Wed, 23 Aug 2023 19:33:19 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] HID: cp2112: make the irqchip immutable

On Wed, 23 Aug 2023 13:14:59 +0100,
Linus Walleij <linus.walleij@...aro.org> wrote:
> 
> On Tue, Aug 22, 2023 at 5:22 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> 
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > This make the GPIO irqchip exposed by the CP2112 driver use an immutable
> > irq_chip struct thus addressing the following warning on probe:
> >
> >   (cp2112_gpio): not an immutable chip, please consider fixing it!
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> Thanks for fixing this. FWIW:
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Marc Z, have you checked how we stand with immutable GPIO
> irqchips? We should be able to smoke it out to default behaviour
> soon I think.

I haven't recently checked, but I'm still in favour of actively
make the new behaviour the only one supported. The sooner we break
things, the better...

	M.

-- 
Without deviation from the norm, progress is not possible.