linux-kernel - Re: [PATCH AUTOSEL 5.15 6/6] drm/amdkfd: ignore crat by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2ac9bbf-b898-1c74-865f-5fea3c580559@amd.com>
Date:   Wed, 23 Aug 2023 14:42:21 -0400
From:   Felix Kuehling <felix.kuehling@....com>
To:     "Deucher, Alexander" <Alexander.Deucher@....com>,
        Sasha Levin <sashal@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Cc:     "Koenig, Christian" <Christian.Koenig@....com>,
        Mike Lothian <mike@...eburn.co.uk>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        "airlied@...il.com" <airlied@...il.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH AUTOSEL 5.15 6/6] drm/amdkfd: ignore crat by default

On 2023-08-22 11:41, Deucher, Alexander wrote:
> [Public]
>
>> -----Original Message-----
>> From: Sasha Levin <sashal@...nel.org>
>> Sent: Tuesday, August 22, 2023 7:37 AM
>> To: linux-kernel@...r.kernel.org; stable@...r.kernel.org
>> Cc: Deucher, Alexander <Alexander.Deucher@....com>; Kuehling, Felix
>> <Felix.Kuehling@....com>; Koenig, Christian <Christian.Koenig@....com>;
>> Mike Lothian <mike@...eburn.co.uk>; Sasha Levin <sashal@...nel.org>; Pan,
>> Xinhui <Xinhui.Pan@....com>; airlied@...il.com; daniel@...ll.ch; amd-
>> gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org
>> Subject: [PATCH AUTOSEL 5.15 6/6] drm/amdkfd: ignore crat by default
>>
>> From: Alex Deucher <alexander.deucher@....com>
>>
>> [ Upstream commit a6dea2d64ff92851e68cd4e20a35f6534286e016 ]
>>
>> We are dropping the IOMMUv2 path, so no need to enable this.
>> It's often buggy on consumer platforms anyway.
> This is not needed for stable.

I agree. I was about to comment in the 5.10 patch as well.

Regards,
   Felix


>
> Alex
>
>> Reviewed-by: Felix Kuehling <Felix.Kuehling@....com>
>> Acked-by: Christian König <christian.koenig@....com>
>> Tested-by: Mike Lothian <mike@...eburn.co.uk>
>> Signed-off-by: Alex Deucher <alexander.deucher@....com>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> ---
>>   drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> index e574aa32a111d..46dfd9baeb013 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> @@ -1523,11 +1523,7 @@ static bool kfd_ignore_crat(void)
>>        if (ignore_crat)
>>                return true;
>>
>> -#ifndef KFD_SUPPORT_IOMMU_V2
>>        ret = true;
>> -#else
>> -     ret = false;
>> -#endif
>>
>>        return ret;
>>   }
>> --
>> 2.40.1