linux-kernel - checkpatch complains about Reported-by block (was: [PATCH v3] tpm: Enable hwrng only for Pluton on AMD CPUs)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a9bf7a1-1664-401d-8cff-3a5d553bdd77@molgen.mpg.de>
Date:   Wed, 23 Aug 2023 21:24:50 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Jarkko Sakkinen <jarkko@...nel.org>,
        Andy Whitcroft <apw@...onical.com>,
        Joe Perches <joe@...ches.com>
Cc:     linux-integrity@...r.kernel.org,
        Jerry Snitselaar <jsnitsel@...hat.com>, stable@...r.kernel.org,
        Todd Brandt <todd.e.brandt@...el.com>,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Mario Limonciello <mario.limonciello@....com>,
        linux-kernel@...r.kernel.org, Patrick Steinhardt <ps@....im>,
        Ronan Pigott <ronan@....ie>,
        Raymond Jay Golo <rjgolo@...il.com>
Subject: checkpatch complains about Reported-by block (was: [PATCH v3] tpm:
 Enable hwrng only for Pluton on AMD CPUs)

[Cc: +Andy, +Joe]


Dear Jarkko, dear Andy, dear Joe,


Am 23.08.23 um 19:40 schrieb Jarkko Sakkinen:
> On Wed Aug 23, 2023 at 11:23 AM EEST, Paul Menzel wrote:

>> Am 23.08.23 um 01:15 schrieb Jarkko Sakkinen:
>>> The vendor check introduced by commit 554b841d4703 ("tpm: Disable RNG for
>>> all AMD fTPMs") doesn't work properly on a number of Intel fTPMs.  On the
>>> reported systems the TPM doesn't reply at bootup and returns back the
>>> command code. This makes the TPM fail probe.
>>>
>>> Since only Microsoft Pluton is the only known combination of AMD CPU and
>>> fTPM from other vendor, disable hwrng otherwise. In order to make sysadmin
>>> aware of this, print also info message to the klog.
>>>
>>> Cc: stable@...r.kernel.org
>>> Fixes: 554b841d4703 ("tpm: Disable RNG for all AMD fTPMs")
>>> Reported-by: Todd Brandt <todd.e.brandt@...el.com>
>>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217804
>>> Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>
>>
>> Mario’s patch also had the three reporters below listed:
>>
>> Reported-by: Patrick Steinhardt <ps@....im>
>> Reported-by: Ronan Pigott <ronan@....ie>
>> Reported-by: Raymond Jay Golo <rjgolo@...il.com>
> 
> The problem here is that checkpatch throws three warnings:
> 
> WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
> #19:
> Reported-by: Patrick Steinhardt <ps@....im>
> Reported-by: Ronan Pigott <ronan@....ie>
> 
> WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
> #20:
> Reported-by: Ronan Pigott <ronan@....ie>
> Reported-by: Raymond Jay Golo <rjgolo@...il.com>
> 
> WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
> #21:
> Reported-by: Raymond Jay Golo <rjgolo@...il.com>
> Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>
> 
> Since bugzilla is not part of the documented process afaik, I used this
> field as the guideline:
> 
> Reported:	2023-08-17 20:59 UTC by Todd Brandt
> 
> How otherwise I should interpret kernel bugzilla?

How is the proper process to add more than one reporter (so they are 
noted and also added to CC), so that checkpatch.pl does not complain?


Kind regards,

Paul


> In any case new version is still needed as the commit message must
> contain a mention of "Lenovo Legion Y540" as the stimulus for doing
> this code change in the first place.
> 
> BR, Jarkko