linux-kernel - Re: [RFC PATCH 1/1] soc: qcom: Add driver to read secondary bootloader (XBL) log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <272adfa0-c053-f737-5714-cbeac706dc76@quicinc.com>
Date:   Wed, 23 Aug 2023 12:32:06 -0700
From:   Trilok Soni <quic_tsoni@...cinc.com>
To:     Ninad Naik <quic_ninanaik@...cinc.com>, <agross@...nel.org>,
        <andersson@...nel.org>, <konrad.dybcio@...aro.org>
CC:     <psodagud@...cinc.com>, <quic_ppareek@...cinc.com>,
        <quic_kprasan@...cinc.com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <kernel@...cinc.com>
Subject: Re: [RFC PATCH 1/1] soc: qcom: Add driver to read secondary
 bootloader (XBL) log

On 8/23/2023 4:16 AM, Ninad Naik wrote:
>>>   ret = map_addr_range(&parent, "uefi-log", xbl_data);
>>
>> Here you are calling it as uefi-log. Is it xbl-log or uefi-log? Please 
>> decide first.
>>
>>
> The reason for using "uefi-log" here is because this node name is in 
> accordance to the sa8775p.dtsi as seen in [2]
> 
> [2] 
> https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/sa8775p.dtsi#L354
> 
> So, in the next revision while adding the device tree bindings and 
> corresponding compatible string, should this node name be changed as well?

Yes, please keep it consistent.

-- 
---Trilok Soni