linux-kernel - Re: [PATCH 1/8] kbuild: do not run depmod for 'make modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOZjmLPxwWik/YOz@bergen.fjasle.eu>
Date:   Wed, 23 Aug 2023 21:52:56 +0200
From:   Nicolas Schier <nicolas@...sle.eu>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH 1/8] kbuild: do not run depmod for 'make modules_sign'

On Wed 23 Aug 2023 20:50:41 GMT, Masahiro Yamada wrote:
> Commit 961ab4a3cd66 ("kbuild: merge scripts/Makefile.modsign to
> scripts/Makefile.modinst") started to run depmod at the end of
> 'make modules_sign'.
> 
> Move the depmod rule to scripts/Makefile.modinst and run it only when
> $(modules_sign_only) is empty.

Moving the depmod rule is in patch 3/8, first half of the sentence 
seems to be left over?

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>

> 
> Fixes: 961ab4a3cd66 ("kbuild: merge scripts/Makefile.modsign to scripts/Makefile.modinst")
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index e0d52539a0f1..7d54a0700c6e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1877,7 +1877,9 @@ quiet_cmd_depmod = DEPMOD  $(MODLIB)
>  
>  modules_install:
>  	$(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst
> +ifndef modules_sign_only
>  	$(call cmd,depmod)
> +endif
>  
>  else # CONFIG_MODULES
>  
> -- 
> 2.39.2

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)