linux-kernel - Re: [PATCH] arc: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DS7PR12MB90416779F78229EDD1750A33A11CA@DS7PR12MB9041.namprd12.prod.outlook.com>
Date:   Wed, 23 Aug 2023 20:43:16 +0000
From:   Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To:     Rob Herring <robh@...nel.org>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vineet Gupta <vgupta@...nel.org>
Subject: Re: [PATCH] arc: Explicitly include correct DT includes

Hi Rob,

> On Fri, Jul 14, 2023 at 11:39:49AM -0600, Rob Herring wrote:
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
> >
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> >  arch/arc/plat-axs10x/axs10x.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Ping!

Thanks for the enhancement!

Tested-by: Alexey Brodkin <abrodkin@...opsys.com>

> 
> >
> > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
> > index b821df7b0089..1feb990a56bc 100644
> > --- a/arch/arc/plat-axs10x/axs10x.c
> > +++ b/arch/arc/plat-axs10x/axs10x.c
> > @@ -6,7 +6,6 @@
> >   */
> > 
> >  #include <linux/of_fdt.h>
> > -#include <linux/of_platform.h>
> >  #include <linux/libfdt.h>
> > 
> >  #include <asm/asm-offsets.h>
> > --
> > 2.40.1
> >