linux-kernel - Re: [PATCH 2/3] clk: lmk04832: Don't disable vco clock on probe fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <521559814e3a4c4990618886b6fd7b8a.sboyd@kernel.org>
Date:   Wed, 23 Aug 2023 15:48:41 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Mike Looijmans <mike.looijmans@...ic.nl>, linux-clk@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, mturquette@...libre.com,
        Mike Looijmans <mike.looijmans@...ic.nl>
Subject: Re: [PATCH 2/3] clk: lmk04832: Don't disable vco clock on probe fail

Quoting Mike Looijmans (2023-08-01 23:40:59)
> The probe() method never calls clk_prepare_enable(), so it should not
> call clk_disable_unprepare() for the vco.clk in the error path. Fixes
> a "lmk-vco already disabled" BUG when probe fails.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
> ---

Applied to clk-next