linux-kernel - Re: [PATCH v3 3/3] clk: qcom: add clock controller driver for qca8386/qca8084

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Aug 2023 13:50:09 +0800
From:   Jie Luo <quic_luoj@...cinc.com>
To:     Stephen Boyd <sboyd@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <catalin.marinas@....com>,
        <conor+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <mturquette@...libre.com>, <p.zabel@...gutronix.de>,
        <robh+dt@...nel.org>, <will@...nel.org>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_srichara@...cinc.com>
Subject: Re: [PATCH v3 3/3] clk: qcom: add clock controller driver for
 qca8386/qca8084



On 8/23/2023 3:10 AM, Stephen Boyd wrote:
> Quoting Jie Luo (2023-08-14 03:58:26)
>>
>>
>> On 8/12/2023 6:56 PM, Konrad Dybcio wrote:
>>> My main point is, why can't you use qcom_cc_really_probe?
>>>
>>
>> Hi Konrad,
>> qcom_cc_really_probe is taking the platform_device as the input
>> parameter, but the nss_cc_qca8k_probe takes the mdio_device as the probe
>> parameter.
> 
> There's no real reason why it takes a platform device instead of a plain
> struct device. You can have an earlier patch change that function to
> take a struct device instead.

Okay, thanks Stephen for the comments, i will update it to use "struct 
device" in the next version.