[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <OS7PR01MB11804F618EF235291066AE96EE51CA@OS7PR01MB11804.jpnprd01.prod.outlook.com>
Date: Wed, 23 Aug 2023 07:07:26 +0000
From: "Daisuke Matsuda (Fujitsu)" <matsuda-daisuke@...itsu.com>
To: "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
CC: "zyjzyj2000@...il.com" <zyjzyj2000@...il.com>,
"jgg@...pe.ca" <jgg@...pe.ca>, "leon@...nel.org" <leon@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"rpearsonhpe@...il.com" <rpearsonhpe@...il.com>,
"Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
Subject: RE: [PATCH v2 1/2] RDMA/rxe: Improve newline in printing messages
On Wed, Aug 23, 2023 3:12 PM Li Zhijian wrote:
>
> Previously rxe_{dbg,info,err}() macros are appened built-in newline,
> sut some users will add redundent newline some times. So remove the
> built-int newline for this macros.
It seems the sentences above contain 4 typos.
Perhaps, you can use a spell checker. (MS Outlook will do.)
>
> In terms of rxe_{dbg,info,err}_xxx() macros, because they don't have
> built-in newline, append newline when using them.
>
> CC: Daisuke Matsuda <matsuda-daisuke@...itsu.com>
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> ---
Great!
I am afraid there are still 4 massages to fix.
Can you check rxe_init_sq() and rxe_init_rq() in rxe_qp.c?
Feel free to add my reviewed-by tag in next revision:
Reviewed-by: Daisuke Matsuda <matsuda-daisuke@...itsu.com>
Daisuke
> I have use below script to verify if all of them are cleanup:
> git grep -n -E "rxe_info.*\"|rxe_err.*\"|rxe_dbg.*\"" drivers/infiniband/sw/rxe/ | grep -v '\\n'
> ---
> drivers/infiniband/sw/rxe/rxe.c | 6 +-
> drivers/infiniband/sw/rxe/rxe.h | 6 +-
> drivers/infiniband/sw/rxe/rxe_comp.c | 4 +-
> drivers/infiniband/sw/rxe/rxe_cq.c | 4 +-
> drivers/infiniband/sw/rxe/rxe_mr.c | 16 +-
> drivers/infiniband/sw/rxe/rxe_mw.c | 2 +-
> drivers/infiniband/sw/rxe/rxe_resp.c | 12 +-
> drivers/infiniband/sw/rxe/rxe_task.c | 4 +-
> drivers/infiniband/sw/rxe/rxe_verbs.c | 216 +++++++++++++-------------
> 9 files changed, 135 insertions(+), 135 deletions(-)
Powered by blists - more mailing lists