linux-kernel - Re: [PATCH] USB: serial: option: add FOXCONN vendor and T99W368/T99W373 product

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZOWyR6T9DP0qj8hG@hovoldconsulting.com>
Date:   Wed, 23 Aug 2023 09:16:23 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Slark Xiao <slark_xiao@....com>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: option: add FOXCONN vendor and
 T99W368/T99W373  product

On Wed, Aug 16, 2023 at 05:37:55PM +0800, Slark Xiao wrote:
> With the increase of the number of Foxconn devices, we add
> a vendor name for Foxconn.

No, please drop the defines. I'm trying to move away from using such
defines as they tend just add more lines to the driver without any
value (and in any case that is a separate change which should have gone
in its own patch).

> The difference of T99W368 and
> T99W373 is the chip solution. T99W368 is designed based
> on Qualcomm SDX65 and T99W373 is SDX62.
> 
> Test evidence as below:

> Both of them share the same port configuration:
> 0&1: MBIM, 2: Modem, 3:GNSS, 4:NMEA, 5:Diag
> GNSS port don't use serial driver.
> 
> Signed-off-by: Slark Xiao <slark_xiao@....com>

Patch looks good otherwise, but please resend without the define change.

Johan