linux-kernel - Re: [PATCH v5 2/2] arm64: dts: qcom: sc7180: Add sku

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d05e2966-8f07-f2b0-0f95-f069a6376635@quanta.corp-partner.google.com>
Date:   Wed, 23 Aug 2023 16:07:00 +0800
From:   Sheng-Liang Pan <sheng-liang.pan@...nta.corp-partner.google.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     dianders@...omium.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        cros-qcom-dts-watchers@...omium.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v5 2/2] arm64: dts: qcom: sc7180: Add sku_id and board id
 for lazor/limozeen

Hi

> On 22.08.2023 12:03, Sheng-Liang Pan wrote:
>> SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0)
>> SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0)
>> SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0)
>>
>> Even though the "no esim" boards are strapped differently than
>> ones that have an esim, the esim isn't represented in the
>> device tree so the same device tree can be used for LTE w/ esim
>> and LTE w/out esim.
>>
>> add BRD_ID(0, Z, 0) = 10 for new board with ALC5682i-VS
>>
>> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@...nta.corp-partner.google.com>
>> ---
> Minor style nits since Doug already suggested a v6:
>
> - please add a space between /delete-node/ and the &reference after it
> - keep properties (e.g. pinctrl-) like this:
>      property-n
>      property-names
>
> Konrad
>
Patch v6 [1] fix it.

[1] 
https://lore.kernel.org/all/20230823151005.v6.2.I8f20fdfe34a2e8a38373bbd65587754b324f3dcb@changeid/