linux-kernel - Re: [PATCH V3 1/2] amba: bus: fix refcount leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaxtfDiTjms_JXCsymPu50rO7POZs5noTKqDz9qQryLrw@mail.gmail.com>
Date:   Wed, 23 Aug 2023 10:22:55 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, frowand.list@...il.com,
        andriy.shevchenko@...ux.intel.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        linux@...linux.org.uk, arnd@...db.de, jeremy.kerr@...onical.com,
        isaacmanjarres@...gle.com, hdegoede@...hat.com,
        ulf.hansson@...aro.org, rafael@...nel.org,
        grant.likely@...retlab.ca, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V3 1/2] amba: bus: fix refcount leak

On Mon, Aug 21, 2023 at 4:34 AM Peng Fan (OSS) <peng.fan@....nxp.com> wrote:

> From: Peng Fan <peng.fan@....com>
>
> commit 5de1540b7bc4 ("drivers/amba: create devices from device tree")
> increases the refcount of of_node, but not releases it in
> amba_device_release, so there is refcount leak. By using of_node_put
> to avoid refcount leak.
>
> Fixes: 5de1540b7bc4 ("drivers/amba: create devices from device tree")
> Signed-off-by: Peng Fan <peng.fan@....com>

Makes sense.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij