linux-kernel - Re: [PATCH] microblaze: Make virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85367a42-0dd4-edba-db42-47475b158c8d@monstr.eu>
Date:   Wed, 23 Aug 2023 10:33:46 +0200
From:   Michal Simek <monstr@...str.eu>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] microblaze: Make virt_to_pfn() a static inline



On 8/23/23 10:07, Linus Walleij wrote:
> On Tue, Aug 8, 2023 at 10:40 AM Linus Walleij <linus.walleij@...aro.org> wrote:
> 
>> +static inline const void *pfn_to_virt(unsigned long pfn)
> 
> I think maybe I should not have put const there. It means the
> pointer shouldn't be modified and I think there is code that
> does that, or cast to some other pointer which is not const:ed
> and then use things like ++ on the resulting type.
> 
> If you run into compile warnings you can just delete the const,
> or I can send a follow-up patch.

Thanks for letting me knoe.

I compiled it by my default toolchain and didn't see any issue.
It should be tmr in linux-next and more bots will run over it.
But if you want to fix it please send the follow up patch on the top of this one 
and I will take it.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP/Versal ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal/Versal NET SoCs
TF-A maintainer - Xilinx ZynqMP/Versal/Versal NET SoCs