linux-kernel - Re: [PATCH v2] usb: typec: tcpm: set initial svdm version based on pd revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023082311-squid-trailing-34dd@gregkh>
Date:   Wed, 23 Aug 2023 11:12:15 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     RD Babiera <rdbabiera@...gle.com>
Cc:     linux@...ck-us.net, heikki.krogerus@...ux.intel.com,
        kyletso@...gle.com, badhri@...gle.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] usb: typec: tcpm: set initial svdm version based on
 pd revision

On Mon, Jul 31, 2023 at 04:59:23PM +0000, RD Babiera wrote:
> When sending Discover Identity messages to a Port Partner that uses Power
> Delivery v2 and SVDM v1, we currently send PD v2 messages with SVDM v2.0,
> expecting the port partner to respond with its highest supported SVDM
> version as stated in Section 6.4.4.2.3 in the Power Delivery v3
> specification. However, sending SVDM v2 to some Power Delivery v2 port
> partners results in a NAK whereas sending SVDM v1 does not.
> 
> NAK messages can be handled by the initiator (PD v3 section 6.4.4.2.5.1),
> and one solution could be to resend Discover Identity on a lower SVDM
> version if possible. But, Section 6.4.4.3 of PD v2 states that "A NAK
> response Should be taken as an indication not to retry that particular
> Command."
> 
> Instead, we can set the SVDM version to the maximum one supported by the
> negotiated PD revision. When operating in PD v2, this obeys Section
> 6.4.4.2.3, which states the SVDM field "Shall be set to zero to indicate
> Version 1.0." In PD v3, the SVDM field "Shall be set to 01b to indicate
> Version 2.0."
> 
> Fixes: c34e85fa69b9 ("usb: typec: tcpm: Send DISCOVER_IDENTITY from dedicated work")
> Cc: stable@...r.kernel.org
> Signed-off-by: RD Babiera <rdbabiera@...gle.com>
> ---
> Changes since v1:
> * Fixed styling errors.

I'll take this now, but again, your email is failing to be
authenticated.  Perhaps install patatt and sign them that way if
google's email infrastructure isn't going to play nice with patches?

Grabbing thread from lore.kernel.org/all/20230731165926.1815338-1-rdbabiera@...gle.com/t.mbox.gz
Analyzing 5 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✗ [PATCH v2] usb: typec: tcpm: set initial svdm version based on pd revision
    + Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com> (✓ DKIM/intel.com)
  ---
  ✗ BADSIG: DKIM/google.com
---
Total patches: 1
---

Hey, if Intel can do it, surely Google can :)

thanks,

greg k-h