linux-kernel - Re: [PATCH v4] PCI/DOE: Expose the DOE protocols via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230823131013.000005b9@Huawei.com>
Date:   Wed, 23 Aug 2023 13:10:13 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Alistair Francis <alistair23@...il.com>
CC:     Lukas Wunner <lukas@...ner.de>,
        Damien Le Moal <dlemoal@...nel.org>, <bhelgaas@...gle.com>,
        <linux-pci@...r.kernel.org>, <alex.williamson@...hat.com>,
        <christian.koenig@....com>, <kch@...dia.com>,
        <gregkh@...uxfoundation.org>, <logang@...tatee.com>,
        <linux-kernel@...r.kernel.org>, <chaitanyak@...dia.com>,
        <rdunlap@...radead.org>,
        Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH v4] PCI/DOE: Expose the DOE protocols via sysfs

On Tue, 15 Aug 2023 14:36:31 -0400
Alistair Francis <alistair23@...il.com> wrote:

> On Sat, Aug 12, 2023 at 4:21 AM Lukas Wunner <lukas@...ner.de> wrote:
> >
> > On Fri, Aug 11, 2023 at 10:03:58AM +0900, Damien Le Moal wrote:  
> > > On 8/11/23 01:33, Alistair Francis wrote:  
> > > > Each DOE feature is exposed as a single file. The files are empty and
> > > > the information is contained in the file name.  
> > >
> > > s/feature/protocol ?  
> >
> > DOE r1.1 replaced all occurrences of "protocol" with the term "feature"
> > or "Data Object Type".
> >
> > PCIe r6.1 (which was published July 24) incorporated that change.
> >
> > So going forward the term "protocol" is deprecated in the DOE context.
> >
> > We should use the terms used by the (latest) PCIe Base Spec so that
> > users can easily make the connection between the language in the spec
> > and our code.
> >
> > Unfortunately this patch uses a mix of "protocol" and "feature".
> > It should use the latter term exclusively.  
> 
> The existing file uses protocols, so I have tried to match the
> existing style. I have changed the names to feature though

Feel free to fix the rest of the file as a precursor ;)

Jonathan

> 
> Alistair
> 
> >
> > Thanks,
> >
> > Lukas