linux-kernel - Re: [PATCH v2 1/2] gpio: sim: dispose of irq mappings before destroying the irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZOYFjtt/+9hPw4u0@smile.fi.intel.com>
Date:   Wed, 23 Aug 2023 16:11:42 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Kent Gibson <warthog618@...il.com>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 1/2] gpio: sim: dispose of irq mappings before
 destroying the irq_sim domain

On Tue, Aug 22, 2023 at 09:29:42PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> If a GPIO simulator device is unbound with interrupts still requested,
> we will hit a use-after-free issue in __irq_domain_deactivate_irq(). The
> owner of the irq domain must dispose of all mappings before destroying
> the domain object.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Fixes: cb8c474e79be ("gpio: sim: new testing module")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
> v1 -> v2:
> - drop the return value check of irq_find_mapping()
> 
>  drivers/gpio/gpio-sim.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index f1f6f1c32987..8fb11a5395eb 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -291,6 +291,15 @@ static void gpio_sim_mutex_destroy(void *data)
>  	mutex_destroy(lock);
>  }
>  
> +static void gpio_sim_dispose_mappings(void *data)
> +{
> +	struct gpio_sim_chip *chip = data;
> +	unsigned int i;
> +
> +	for (i = 0; i < chip->gc.ngpio; i++)
> +		irq_dispose_mapping(irq_find_mapping(chip->irq_sim, i));
> +}
> +
>  static void gpio_sim_sysfs_remove(void *data)
>  {
>  	struct gpio_sim_chip *chip = data;
> @@ -406,6 +415,10 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
>  	if (IS_ERR(chip->irq_sim))
>  		return PTR_ERR(chip->irq_sim);
>  
> +	ret = devm_add_action_or_reset(dev, gpio_sim_dispose_mappings, chip);
> +	if (ret)
> +		return ret;
> +
>  	mutex_init(&chip->lock);
>  	ret = devm_add_action_or_reset(dev, gpio_sim_mutex_destroy,
>  				       &chip->lock);
> -- 
> 2.39.2
> 

-- 
With Best Regards,
Andy Shevchenko