linux-kernel - Re: [PATCH v2] staging: vt6655: replace camel case by snake case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Aug 2023 19:02:40 +0530
From:   Pavan Bobba <opensource206@...il.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Forest Bond <forest@...ttletooquiet.net>,
        Michael Straube <straube.linux@...il.com>,
        Philipp Hortmann <philipp.g.hortmann@...il.com>,
        outreachy@...ts.linux.dev, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: vt6655: replace camel case by snake case

On Wed, Aug 23, 2023 at 02:58:38PM +0200, Julia Lawall wrote:
> 
> >  		}
> > -		if ((wDelay < W_MAX_TIMEOUT) &&
> > -		    (!(byWait & I2MCSR_NACK))) {
> > +		if ((delay < W_MAX_TIMEOUT) &&
> 
> Maybe the W_ should also be dropped?
even non staging driver have this
https://elixir.bootlin.com/linux/v6.5-rc7/source/drivers/net/ethernet/via/via-velocity.h#L959

> >   *  Out:
> > - *      pbyEepromRegs   - EEPROM content Buffer
> > + *      eepromregs   - EEPROM content Buffer
> 
> Here you could add some spaces to get the - EEPROM to line up with the
> rest.  Likewise later.
> 
> julia

ok 

> >   *
> >   * Return Value: none
> >   *
> >   */
> > -void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyEepromRegs)
> > +void SROMvReadAllContents(void __iomem *iobase, unsigned char *eepromregs)
> >  {
> >  	int     ii;
> >
> >  	/* ii = Rom Address */
> >  	for (ii = 0; ii < EEP_MAX_CONTEXT_SIZE; ii++) {
> > -		*pbyEepromRegs = SROMbyReadEmbedded(iobase,
> > +		*eepromregs = SROMbyReadEmbedded(iobase,
> >  						    (unsigned char)ii);
> > -		pbyEepromRegs++;
> > +		eepromregs++;
> >  	}
> >  }
> >
> > @@ -122,19 +122,19 @@ void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyEepromRegs)
> >   *  In:
> >   *      iobase          - I/O base address
> >   *  Out:
> > - *      pbyEtherAddress - Ethernet Address buffer
> > + *      etheraddress - Ethernet Address buffer
> >   *
> >   * Return Value: none
> >   *
> >   */
> >  	}
> >  }
> > --
> > 2.34.1
> >
> >
> >