linux-kernel - Re: [PATCH] char: hw_random: ba431-rng: removed unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230823134017.gguqgagcbb7tvnxc@viti.kaiser.cx>
Date:   Wed, 23 Aug 2023 15:40:17 +0200
From:   Martin Kaiser <lists@...ser.cx>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        alex@...uggie.ro, herbert@...dor.apana.org.au, olivia@...enic.com
Subject: Re: [PATCH] char: hw_random: ba431-rng: removed unneeded call to
 platform_set_drvdata()

Andrei Coardos (aboutphysycs@...il.com) wrote:

> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.

> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
>  drivers/char/hw_random/ba431-rng.c | 2 --
>  1 file changed, 2 deletions(-)

> diff --git a/drivers/char/hw_random/ba431-rng.c b/drivers/char/hw_random/ba431-rng.c
> index 5b7ca0416490..b1518dd52a24 100644
> --- a/drivers/char/hw_random/ba431-rng.c
> +++ b/drivers/char/hw_random/ba431-rng.c
> @@ -189,8 +189,6 @@ static int ba431_trng_probe(struct platform_device *pdev)
>  	ba431->rng.cleanup = ba431_trng_cleanup;
>  	ba431->rng.read = ba431_trng_read;

> -	platform_set_drvdata(pdev, ba431);
> -
>  	ret = devm_hwrng_register(&pdev->dev, &ba431->rng);
>  	if (ret) {
>  		dev_err(&pdev->dev, "BA431 registration failed (%d)\n", ret);
> -- 
> 2.34.1

This was already removed in e8c1fdcc62d3 ("hwrng: ba431 - do not set
drvdata").