linux-kernel - Re: [PATCH] wireless: ath: remove unused-but-set parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 Aug 2023 14:12:24 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Jeff Johnson <quic_jjohnson@...cinc.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Nick Kossifidis <mickflemm@...il.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Toke Høiland-Jørgensen 
        <toke@...e.dk>, Arnd Bergmann <arnd@...db.de>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>,
        Aloka Dixit <quic_alokad@...cinc.com>,
        Wen Gong <quic_wgong@...cinc.com>,
        Ramya Gnanasekar <quic_rgnanase@...cinc.com>,
        Karthik M <quic_karm@...cinc.com>,
        Aditya Kumar Singh <quic_adisi@...cinc.com>,
        Muna Sinada <quic_msinada@...cinc.com>,
        Johannes Berg <johannes.berg@...el.com>,
        ath12k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] wireless: ath: remove unused-but-set parameter

Arnd Bergmann <arnd@...nel.org> wrote:

> This has never been used since the driver was merged, but it now causes
> a W=1 warning in recent clang versions
> 
> drivers/net/wireless/ath/ath9k/main.c:1566:21: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> drivers/net/wireless/ath/ath9k/htc_drv_main.c:1258:25: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> drivers/net/wireless/ath/ath5k/mac80211-ops.c:367:62: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> 
> Remove the bit manipulation on the otherwise unused parameter.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Reviewed-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> Acked-by: Toke Høiland-Jørgensen <toke@...e.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

Patch applied to ath-next branch of ath.git, thanks.

3b86f86d0f16 wifi: ath: remove unused-but-set parameter

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230814073255.1065242-1-arnd@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches