linux-kernel - Re: [PATCH v2] ath5k: fix WARNING opportunity for swap.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169280018252.1336947.9195494625523438821.kvalo@kernel.org>
Date:   Wed, 23 Aug 2023 14:16:24 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Mahmoud Maatuq <mahmoudmatook.mm@...il.com>
Cc:     jirislaby@...nel.org, mickflemm@...il.com, mcgrof@...nel.org,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Mahmoud Maatuq <mahmoudmatook.mm@...il.com>
Subject: Re: [PATCH v2] ath5k: fix WARNING opportunity for swap.

Mahmoud Maatuq <mahmoudmatook.mm@...il.com> wrote:

> coccinielle reported the following:
> ./drivers/net/wireless/ath/ath5k/phy.c:1573:25-26: WARNING opportunity for swap()
> 
> while trying to fix the above warning, it reveals that ath5k_hw_get_median_noise_floor()
> had open-coded sort() functionality. Since ath5k_hw_get_median_noise_floor() only
> executes once every 10 seconds, any extra overhead due to sort() calling
> its "compare" and "swap" functions can be ignored, so replace the
> existing logic with a call to sort().
> 
> Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@...il.com>
> Suggested-by: Jiri Slaby <jirislaby@...nel.org>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

Patch applied to ath-next branch of ath.git, thanks.

e10ec6ea612c wifi: ath5k: ath5k_hw_get_median_noise_floor(): use swap()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230815040819.649455-1-mahmoudmatook.mm@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches