[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <27f9009ce2a1440290de672adf379bcd@realtek.com>
Date: Wed, 23 Aug 2023 14:25:55 +0000
From: Justin Lai <justinlai0215@...ltek.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "kuba@...nel.org" <kuba@...nel.org>,
"davem@...emloft.net" <davem@...emloft.net>,
"edumazet@...gle.com" <edumazet@...gle.com>,
"pabeni@...hat.com" <pabeni@...hat.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"jiri@...nulli.us" <jiri@...nulli.us>
Subject: RE: [PATCH net-next v6 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code
> > +static int rtase_set_pauseparam(struct net_device *dev, struct
> > +ethtool_pauseparam *pause) {
> > + const struct rtase_private *tp = netdev_priv(dev);
> > + u16 value = RTL_R16(tp, CPLUS_CMD);
> > +
> > + value &= ~(FORCE_TXFLOW_EN | FORCE_RXFLOW_EN);
> > +
> > + if (pause->tx_pause)
> > + value |= FORCE_TXFLOW_EN;
> > +
> > + if (pause->rx_pause)
> > + value |= FORCE_RXFLOW_EN;
> > +
> > + RTL_W16(tp, CPLUS_CMD, value);
> > + return 0;
> > +}
>
> I'm pretty sure i said if pause->autoneg is true, you should return
> -EOPNOTUSPP.
>
> Andrew
Sorry this part has not been changed, I will modify this part in the next version.
Powered by blists - more mailing lists