[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <42b7123c-2688-48cb-6f8a-96996338f963@acm.org>
Date: Wed, 23 Aug 2023 07:46:47 -0700
From: Bart Van Assche <bvanassche@....org>
To: chengming.zhou@...ux.dev, axboe@...nel.dk, ming.lei@...hat.com,
hch@....de
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
zhouchengming@...edance.com
Subject: Re: [PATCH v2 6/6] blk-mq-tag: fix blk_mq_queue_tag_busy_iter()
documentation
On 8/23/23 02:04, chengming.zhou@...ux.dev wrote:
> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
> index 087ea6b232f6..69b156750559 100644
> --- a/block/blk-mq-tag.c
> +++ b/block/blk-mq-tag.c
> @@ -312,6 +312,7 @@ static bool bt_tags_iter(struct sbitmap *bitmap, unsigned int bitnr, void *data)
> * tags, false to stop.
> * @data: Will be passed as second argument to @fn.
> * @flags: BT_TAG_ITER_*
> + * @q: Only iterate over requests of this queue.
> */
Please integrate this change in patch 2/6 since the argument 'q' is added by that
patch.
> @@ -432,8 +433,7 @@ EXPORT_SYMBOL(blk_mq_tagset_wait_completed_request);
> * @priv: Will be passed as second argument to @fn.
> *
> * Note: if @q->tag_set is shared with other request queues then @fn will be
> - * called for all requests on all queues that share that tag set and not only
> - * for requests associated with @q.
> + * called only for requests associated with @q.
> */
> void blk_mq_queue_tag_busy_iter(struct request_queue *q, busy_tag_iter_fn *fn,
> void *priv)
Please consider adding the following to this change:
Fixes: c7b1bf5cca76 ("blk-mq: Document the functions that iterate over requests")
Powered by blists - more mailing lists