linux-kernel - Re: [PATCH v7 1/1] vfio/nvgpu: Add vfio pci variant module for grace hopper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Aug 2023 12:16:23 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     Ankit Agrawal <ankita@...dia.com>,
        Yishai Hadas <yishaih@...dia.com>,
        "shameerali.kolothum.thodi@...wei.com" 
        <shameerali.kolothum.thodi@...wei.com>,
        "kevin.tian@...el.com" <kevin.tian@...el.com>,
        Aniket Agashe <aniketa@...dia.com>, Neo Jia <cjia@...dia.com>,
        Kirti Wankhede <kwankhede@...dia.com>,
        "Tarun Gupta (SW-GPU)" <targupta@...dia.com>,
        Vikram Sethi <vsethi@...dia.com>,
        Andy Currid <acurrid@...dia.com>,
        Alistair Popple <apopple@...dia.com>,
        John Hubbard <jhubbard@...dia.com>,
        Dan Williams <danw@...dia.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 1/1] vfio/nvgpu: Add vfio pci variant module for grace
 hopper

On Wed, Aug 23, 2023 at 09:14:07AM -0600, Alex Williamson wrote:
> On Wed, 23 Aug 2023 14:50:31 +0000
> Ankit Agrawal <ankita@...dia.com> wrote:
> 
> > >> +     if (index == VFIO_PCI_BAR2_REGION_INDEX) {
> > >> +             if (!nvdev->opregion) {
> > >> +                     nvdev->opregion = memremap(nvdev->hpa, nvdev->mem_length, MEMREMAP_WB);
> > >> +                     if (!nvdev->opregion)
> > >> +                             return -ENOMEM;
> > >> +             }  
> > >
> > > [AW] Seems like this would be susceptible to concurrent accesses causing
> > > duplicate mappings.
> > >
> > > [JG] Needs some kind of locking on opregion  
> > 
> > Right, will add a new lock item in nvdev to control the access to opregion/memmap.
> > Please let me know if it is preferable to do memremap in open_device instead of
> > read/write.
> 
> That's a valid option also, certainly avoids the locking and
> serialization per access.  Thanks,

open_device is no good, that would waste large amounts of kernel
memory for page tables to support something we don't expect to be
used.

Jason