linux-kernel - Re: [PATCH] watchdog: stm32: Drop unnecessary of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <970cbe44-9958-4315-b112-74f34bf97740@roeck-us.net>
Date:   Wed, 23 Aug 2023 08:38:06 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Rob Herring <robh@...nel.org>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        kernel test robot <lkp@...el.com>,
        linux-watchdog@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: stm32: Drop unnecessary of_match_ptr()

On Wed, Aug 23, 2023 at 10:10:59AM -0500, Rob Herring wrote:
> With COMPILE_TEST recently enabled, 0-day reports a warning:
> 
> drivers/watchdog/stm32_iwdg.c:215:34: warning: 'stm32_iwdg_of_match' defined but not used [-Wunused-const-variable=]
> 
> As STM32 platforms are always used with DT, drop the of_match_ptr().
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308211837.4VBSUAtZ-lkp@intel.com/
> Signed-off-by: Rob Herring <robh@...nel.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/stm32_iwdg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
> index 570a71509d2a..9a554a3db4e2 100644
> --- a/drivers/watchdog/stm32_iwdg.c
> +++ b/drivers/watchdog/stm32_iwdg.c
> @@ -288,7 +288,7 @@ static struct platform_driver stm32_iwdg_driver = {
>  	.probe		= stm32_iwdg_probe,
>  	.driver = {
>  		.name	= "iwdg",
> -		.of_match_table = of_match_ptr(stm32_iwdg_of_match),
> +		.of_match_table = stm32_iwdg_of_match,
>  	},
>  };
>  module_platform_driver(stm32_iwdg_driver);
> -- 
> 2.40.1
>