linux-kernel - Re: [PATCH v1] Revert "ASoC: Intel: Add rpl_nau8318

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALprXBYxrwBW6HLP5MwYhFh1_Skei+pLbXd7yNAEuhLTQJLVPg@mail.gmail.com>
Date:   Wed, 23 Aug 2023 23:45:09 +0800
From:   Ajye Huang <ajye_huang@...pal.corp-partner.google.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Akihiko Odaki <akihiko.odaki@...il.com>,
        Yong Zhi <yong.zhi@...el.com>,
        ye xingchen <ye.xingchen@....com.cn>,
        "balamurugan . c" <balamurugan.c@...el.com>,
        Libin Yang <libin.yang@...el.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        David Lin <CTLIN0@...oton.com>, Brent Lu <brent.lu@...el.com>,
        Takashi Iwai <tiwai@...e.com>,
        Terry Cheong <htcheong@...omium.org>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Gongjun Song <gongjun.song@...el.com>,
        Arnd Bergmann <arnd@...db.de>, apoorv <apoorv@...el.com>,
        alsa-devel@...a-project.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v1] Revert "ASoC: Intel: Add rpl_nau8318_8825 driver"

On Wed, Aug 23, 2023 at 8:01 PM Mark Brown <broonie@...nel.org> wrote:
> 6b8b6892e434 is not applied?
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

Dear Mark,
Please allow me to explain in more detail.
The 6b8b6892e434 should not be applied into file0yZ50U branch of broonie/ci.git.
Because the original commit 273bc8bf2227 ("ASoC: Intel: Add
rpl_nau8318_8825 driver") was applied on 2023-08-14.
But two days ago, 6b8b6892e434 tried to commit THE SAME patch again on
2023-08-21, but it just only added a little part content from original
273bc8bf2227.
+static const struct snd_soc_acpi_codecs rpl_nau8318_amp = {
+ .num_codecs = 1,
+ .codecs = {"NVTN2012"}
+};
+
It caused "rpl_nau8318_amp" to be redefined.
This condition only happens at broonie/ci.git's file0yZ50U branch.

Could you check this one again?  thanks.