| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Aug 2023 12:56:29 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
James Clark <james.clark@....com>,
Kan Liang <kan.liang@...ux.intel.com>,
John Garry <john.g.garry@...cle.com>,
Kajol Jain <kjain@...ux.ibm.com>,
Jing Zhang <renyu.zj@...ux.alibaba.com>,
Ravi Bangoria <ravi.bangoria@....com>,
Rob Herring <robh@...nel.org>,
Gaosheng Cui <cuigaosheng1@...wei.com>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 00/25] Lazily load PMU data
Em Wed, Aug 23, 2023 at 01:08:03AM -0700, Ian Rogers escreveu:
> Lazily load PMU data both from sysfs and json files. Reorganize
> json data to be more PMU oriented to facilitate this, for
> example, json data is now sorted into arrays for their PMU.
>
> In refactoring the code some changes were made to get rid of maximum
> encoding sizes for events (256 bytes), with input files being directly
> passed to the lex generated code. There is also a small event parse
> error message improvement.
>
> Some results from an Intel tigerlake laptop running Debian:
>
> Binary size reduction of 1.4% or 143,264 bytes because the PMU
> name no longer appears in the string.
>
> stat -e cpu/cycles/ minor faults reduced from 1733 to 1667, open calls reduced
> from 171 to 94.
>
> stat default minor faults reduced from 1085 to 1727, open calls reduced
> from 654 to 343.
>
> Average PMU scanning reduced from 4720.641usec to 2927.293usec.
> Average core PMU scanning reduced from 1004.658usec to 232.668usec
> (4.3x faster).
I'm now chasing this one when building it on ubuntu arm64
CC /tmp/build/perf/util/env.o
arch/arm64/util/../../arm/util/cs-etm.c: In function 'cs_etm_validate_context_id':
arch/arm64/util/../../arm/util/cs-etm.c:82:26: error: passing argument 1 of 'perf_pmu__format_bits' from incompatible pointer type [-Werror=incompatible-pointer-types]
(perf_pmu__format_bits(&cs_etm_pmu->format, "contextid") |
^
In file included from arch/arm64/util/../../arm/util/../../../util/header.h:13:0,
from arch/arm64/util/../../arm/util/../../../util/session.h:7,
from arch/arm64/util/../../arm/util/cs-etm.c:31:
arch/arm64/util/../../arm/util/../../../util/pmu.h:224:7: note: expected 'struct perf_pmu *' but argument is of type 'struct list_head *'
__u64 perf_pmu__format_bits(struct perf_pmu *pmu, const char *name);
^~~~~~~~~~~~~~~~~~~~~
arch/arm64/util/../../arm/util/cs-etm.c:83:26: error: passing argument 1 of 'perf_pmu__format_bits' from incompatible pointer type [-Werror=incompatible-pointer-types]
perf_pmu__format_bits(&cs_etm_pmu->format, "contextid1") |
^
In file included from arch/arm64/util/../../arm/util/../../../util/header.h:13:0,
from arch/arm64/util/../../arm/util/../../../util/session.h:7,
from arch/arm64/util/../../arm/util/cs-etm.c:31:
arch/arm64/util/../../arm/util/../../../util/pmu.h:224:7: note: expected 'struct perf_pmu *' but argument is of type 'struct list_head *'
__u64 perf_pmu__format_bits(struct perf_pmu *pmu, const char *name);
^~~~~~~~~~~~~~~~~~~~~
arch/arm64/util/../../arm/util/cs-etm.c:84:26: error: passing argument 1 of 'perf_pmu__format_bits' from incompatible pointer type [-Werror=incompatible-pointer-types]
perf_pmu__format_bits(&cs_etm_pmu->format, "contextid2"));
^
In file included from arch/arm64/util/../../arm/util/../../../util/header.h:13:0,
from arch/arm64/util/../../arm/util/../../../util/session.h:7,
from arch/arm64/util/../../arm/util/cs-etm.c:31:
arch/arm64/util/../../arm/util/../../../util/pmu.h:224:7: note: expected 'struct perf_pmu *' but argument is of type 'struct list_head *'
__u64 perf_pmu__format_bits(struct perf_pmu *pmu, const char *name);
^~~~~~~~~~~~~~~~~~~~~
arch/arm64/util/../../arm/util/cs-etm.c:109:28: error: passing argument 1 of 'perf_pmu__format_bits' from incompatible pointer type [-Werror=incompatible-pointer-types]
perf_pmu__format_bits(&cs_etm_pmu->format, "contextid1")) {
^
In file included from arch/arm64/util/../../arm/util/../../../util/header.h:13:0,
from arch/arm64/util/../../arm/util/../../../util/session.h:7,
from arch/arm64/util/../../arm/util/cs-etm.c:31:
arch/arm64/util/../../arm/util/../../../util/pmu.h:224:7: note: expected 'struct perf_pmu *' but argument is of type 'struct list_head *'
__u64 perf_pmu__format_bits(struct perf_pmu *pmu, const char *name);
^~~~~~~~~~~~~~~~~~~~~
arch/arm64/util/../../arm/util/cs-etm.c:125:28: error: passing argument 1 of 'perf_pmu__format_bits' from incompatible pointer type [-Werror=incompatible-pointer-types]
perf_pmu__format_bits(&cs_etm_pmu->format, "contextid2")) {
^
In file included from arch/arm64/util/../../arm/util/../../../util/header.h:13:0,
from arch/arm64/util/../../arm/util/../../../util/session.h:7,
from arch/arm64/util/../../arm/util/cs-etm.c:31:
arch/arm64/util/../../arm/util/../../../util/pmu.h:224:7: note: expected 'struct perf_pmu *' but argument is of type 'struct list_head *'
__u64 perf_pmu__format_bits(struct perf_pmu *pmu, const char *name);
^~~~~~~~~~~~~~~~~~~~~
CC /tmp/build/perf/bench/epoll-ctl.o
arch/arm64/util/../../arm/util/cs-etm.c: In function 'cs_etm_validate_timestamp':
arch/arm64/util/../../arm/util/cs-etm.c:154:30: error: passing argument 1 of 'perf_pmu__format_bits' from incompatible pointer type [-Werror=incompatible-pointer-types]
perf_pmu__format_bits(&cs_etm_pmu->format, "timestamp")))
^
In file included from arch/arm64/util/../../arm/util/../../../util/header.h:13:0,
from arch/arm64/util/../../arm/util/../../../util/session.h:7,
from arch/arm64/util/../../arm/util/cs-etm.c:31:
arch/arm64/util/../../arm/util/../../../util/pmu.h:224:7: note: expected 'struct perf_pmu *' but argument is of type 'struct list_head *'
__u64 perf_pmu__format_bits(struct perf_pmu *pmu, const char *name);
^~~~~~~~~~~~~~~~~~~~~
CC /tmp/build/perf/tests/vmlinux-kallsyms.o
CC /tmp/build/perf/arch/arm64/util/mem-events.o
CC /tmp/build/perf/bench/synthesize.o
CC /tmp/build/perf/tests/perf-record.o
CC /tmp/build/perf/bench/kallsyms-parse.o
arch/arm64/util/arm-spe.c: In function 'arm_spe_recording_options':
arch/arm64/util/arm-spe.c:233:30: error: passing argument 1 of 'perf_pmu__format_bits' from incompatible pointer type [-Werror=incompatible-pointer-types]
bit = perf_pmu__format_bits(&arm_spe_pmu->format, "pa_enable");
^
In file included from arch/arm64/util/../../../util/header.h:13:0,
from arch/arm64/util/../../../util/session.h:7,
from arch/arm64/util/arm-spe.c:19:
arch/arm64/util/../../../util/pmu.h:224:7: note: expected 'struct perf_pmu *' but argument is of type 'struct list_head *'
__u64 perf_pmu__format_bits(struct perf_pmu *pmu, const char *name);
^~~~~~~~~~~~~~~~~~~~~
CC /tmp/build/perf/bench/find-bit-bench.o
CC /tmp/build/perf/tests/evsel-roundtrip-name.o
CC /tmp/build/perf/bench/inject-buildid.o
CC /tmp/build/perf/util/event.o
Powered by blists - more mailing lists