linux-kernel - Re: [PATCH v3] dt-bindings: irqchip: convert st,stih407-irq-syscfg to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79c6a70b-47f1-b625-46a5-617b895ded91@linaro.org>
Date:   Thu, 24 Aug 2023 18:41:22 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Raphaël Gallais-Pou <rgallaispou@...il.com>,
        Rob Herring <robh@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Patrice Chotard <patrice.chotard@...s.st.com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v3] dt-bindings: irqchip: convert st,stih407-irq-syscfg to
 DT schema

On 24/08/2023 18:32, Raphaël Gallais-Pou wrote:
>>> +  st,invert-ext:
>>> +    description: External IRQs can be inverted at will. This property inverts
>>> +      these IRQs using bitwise logic.
>>
>> So this is a mask?
> 
> Of course, I did not had clarity given the hour I sent this, but it is 
> indeed a bitmask.
>>
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +    enum: [ 1, 2, 4]
>>
>> If so, then this is wrong if you want to set more than 1 bit.
> So knowing this is a mask, it can take any integer between 1 and 4 in 
> our case.

No, 1 + 4 = 5. *more than 1 bit*

Best regards,
Krzysztof