linux-kernel - Re: [PATCH] seccomp: Remove unnecessary ‘NULL’ values from prepared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202308240941.E3CC7885E@keescook>
Date:   Thu, 24 Aug 2023 09:42:56 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Li zeming <zeming@...china.com>
Cc:     luto@...capital.net, wad@...omium.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] seccomp: Remove unnecessary ‘NULL’ values from prepared

On Sat, Aug 26, 2023 at 02:43:48AM +0800, Li zeming wrote:
> prepared is assigned first, so it does not need to initialize the 
> assignment.

I prefer to explicitly initialize variables so that later changes in
the code cannot suddenly leave a variable in a surprise state. :) The
compiler will do a good job removing redundant and dead stores.

-Kees

-- 
Kees Cook