linux-kernel - Re: [PATCH] ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r0ns8hej.wl-tiwai@suse.de>
Date:   Thu, 24 Aug 2023 19:44:04 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     SungHwan Jung <onenowy@...il.com>
Cc:     fabian@...ter-vogt.de, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, perex@...ex.cz, tiwai@...e.com
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx

On Thu, 24 Aug 2023 19:37:18 +0200,
SungHwan Jung wrote:
> 
> On Fri, Aug 25, 2023 at 12:57 AM Fabian Vogt <fabian@...ter-vogt.de> wrote:
> > I see that SungHwan Jung (CC'd) recently submitted the same fixup for
> > a rather similar but different model as
> > "ALSA: hda/realtek: Add quirk for HP Victus 16-d1xxx to enable mute LED"
> > Does your HP Victus also need the ALC245_FIXUP_HP_GPIO_LED? Then we could
> > combine the quirks.
> 
> These victus laptops don't need ALC245_FIXUP_HP_GPIO_LED, but we can make
> alc245_fixup_hp_x360_mute_led and alc245_fixup_hp_mute_led_coefbit into
> one function.

ShungHwan's patch was already merged, so we can just reuse the
function in a new quirk; ALC245_FIXUP_HP_X360_MUTE_LED will be calling
alc245_fixup_hp_mute_led_coefbit and chained to
ALC245_FIXUP_HP_GPIO_LED.

Fabian, could you resubmit such a patch?


thanks,

Takashi