linux-kernel - Re: [EXT] Re: [PATCH v4 6/7] firmware: imx: add driver for NXP EdgeLock Enclave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <949e6b65-653b-7b9d-00de-3541b7579bdc@linaro.org>
Date:   Thu, 24 Aug 2023 20:43:05 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Pankaj Gupta <pankaj.gupta@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "clin@...e.com" <clin@...e.com>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "pierre.gondois@....com" <pierre.gondois@....com>,
        Jacky Bai <ping.bai@....com>,
        Clark Wang <xiaoning.wang@....com>,
        Wei Fang <wei.fang@....com>, Peng Fan <peng.fan@....com>,
        Bough Chen <haibo.chen@....com>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gaurav Jain <gaurav.jain@....com>,
        "alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>,
        Sahil Malhotra <sahil.malhotra@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        Varun Sethi <V.Sethi@....com>
Cc:     kernel test robot <lkp@...el.com>
Subject: Re: [EXT] Re: [PATCH v4 6/7] firmware: imx: add driver for NXP
 EdgeLock Enclave

On 08/08/2023 14:36, Pankaj Gupta wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> Sent: Thursday, July 13, 2023 12:27 AM
>> To: Pankaj Gupta <pankaj.gupta@....com>; shawnguo@...nel.org;
>> s.hauer@...gutronix.de; kernel@...gutronix.de; clin@...e.com;
>> conor+dt@...nel.org; pierre.gondois@....com; Jacky Bai
>> <ping.bai@....com>; Clark Wang <xiaoning.wang@....com>; Wei Fang
>> <wei.fang@....com>; Peng Fan <peng.fan@....com>; Bough Chen
>> <haibo.chen@....com>; festevam@...il.com; dl-linux-imx <linux-
>> imx@....com>; davem@...emloft.net; robh+dt@...nel.org;
>> krzysztof.kozlowski+dt@...aro.org; linux-arm-kernel@...ts.infradead.org;
>> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; Gaurav Jain
>> <gaurav.jain@....com>; alexander.stein@...tq-group.com; Sahil Malhotra
>> <sahil.malhotra@....com>; Aisheng Dong <aisheng.dong@....com>; Varun
>> Sethi <V.Sethi@....com>
>> Cc: kernel test robot <lkp@...el.com>
>> Subject: [EXT] Re: [PATCH v4 6/7] firmware: imx: add driver for NXP EdgeLock
>> Enclave
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On 12/07/2023 14:12, Pankaj Gupta wrote:
>>> The Edgelock Enclave , is the secure enclave embedded in the SoC to
>>> support the features like HSM, SHE & V2X, using message based
>>> communication channel.
>>>
>>> ELE FW communicates on a dedicated MU with application core where
>>> kernel is running. It exists on specific i.MX processors. e.g.
>>> i.MX8ULP, i.MX93.
>>>
>>> Signed-off-by: Gaurav Jain <gaurav.jain@....com>
>>> Signed-off-by: Pankaj Gupta <pankaj.gupta@....com>
>>> Reported-by: kernel test robot <lkp@...el.com>
>>
>> What did the robot report? New driver?
> [Pankaj] reported printf format-specifier for size_t. 

That's not what you said here. You said robot reported the driver.

...

>>> +
>>> +     pr_info("Misc-devices on i.MX enclave MU is configured.\n");
>>
>> No silly probe success messages.
> [Accepted] Will removed in V5.

I still found more.

>>
>>
>>> +     return devm_of_platform_populate(dev);
>>
>> No. You do not have children. Just open your own binding and look there.
>>
>> This driver is in terrible shape and I asked to do some internal review in NXP.
>> Internal review should point such trivial comments but your changelog from
>> v1 tp v4 says nothing about it.
>>
>> So internal review did not happen. Don't use upstream as cheap reviewers for
>> poor quality code. Please work internally till it starts looking correct and all
>> automated tools pass. NXP is not some small, amateour company which can be
>> excused of this. Or is it?

I don't think much improved here... Still no coccinelle, probably no
other tools. You Cc-ed like 10 NXP people, for what? Did they provide
reviews?

Best regards,
Krzysztof