linux-kernel - Re: [PATCHv2] dma-debug: don't call __dma_entry_alloc_check_leak() under free_entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230824031542.GB610023@google.com>
Date:   Thu, 24 Aug 2023 12:15:42 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Christoph Hellwig <hch@....de>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Robin Murphy <robin.murphy@....com>
Cc:     Rob Clark <robdclark@...omium.org>, Petr Mladek <pmladek@...e.com>,
        John Ogness <john.ogness@...utronix.de>,
        linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: [PATCHv2] dma-debug: don't call __dma_entry_alloc_check_leak()
 under free_entries_lock

On (23/08/16 11:32), Sergey Senozhatsky wrote:
> __dma_entry_alloc_check_leak() calls into printk -> serial console
> output (qcom geni) and grabs port->lock under free_entries_lock
> spin lock, which is a reverse locking dependency chain as qcom_geni
> IRQ handler can call into dma-debug code and grab free_entries_lock
> under port->lock.
> 
> Move __dma_entry_alloc_check_leak() call out of free_entries_lock
> scope so that we don't acquire serial console's port->lock under it.

Hello folks,

Have you got a chance to take a look at the patch?