linux-kernel - seqlock:do_raw_write_seqcount_end smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <3eedf328-d588-cbd2-ee99-55dc776bdf5b@quicinc.com>
Date:   Thu, 24 Aug 2023 09:07:57 +0800
From:   Kassey Li <quic_yingangl@...cinc.com>
To:     Peter Zijlstra <peterz@...radead.org>, <mingo@...hat.com>,
        <will@...nel.org>, <boqun.feng@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: seqlock:do_raw_write_seqcount_end smp_wmb

hi, Peter:
	I not quit sure on this, but is that a type error in 
do_raw_write_seqcount_end here  ?
is this change necessary to match with do_raw_write_seqcount_begin ?
		
	
diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index 987a59d977c5..eb8807ed3a00 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -486,8 +486,8 @@ do { 
                        \

  static inline void do_raw_write_seqcount_end(seqcount_t *s)
  {
-       smp_wmb();
         s->sequence++;
+       smp_wmb();
         kcsan_nestable_atomic_end();
  }


to match with

static inline void do_raw_write_seqcount_begin(seqcount_t *s)
{
	kcsan_nestable_atomic_begin();
	s->sequence++;
	smp_wmb();
}



BR
TNT