[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <405e420d-ba17-4a20-9cec-11e821b73bbf@collabora.com>
Date: Fri, 25 Aug 2023 00:19:34 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
kernel@...labora.com
Subject: Re: [PATCH] ASoC: soc-core.c: Do not error if a DAI link component is
not found
On 8/24/23 23:04, Mark Brown wrote:
> On Thu, Aug 24, 2023 at 10:38:37PM +0300, Cristian Ciocaltea wrote:
>> A recent cleanup of soc_dai_link_sanity_check() is responsible for
>> generating lots of confusing errors before returning -EPROBE_DEFER:
>>
>> acp5x_mach acp5x_mach.0: ASoC: Component acp5x_i2s_dma.0 not found for link acp5x-8821-play
>> [...]
>> acp5x_mach acp5x_mach.0: ASoC: Component spi-VLV1776:00 not found for link acp5x-CS35L41-Stereo
>> [...]
>> acp5x_mach acp5x_mach.0: ASoC: Component spi-VLV1776:01 not found for link acp5x-CS35L41-Stereo
>>
>> Switch back to the initial behaviour of logging those messages on
>> KERN_DEBUG level instead of KERN_ERR.
>>
>> While at it, use the correct form of the verb in 'component_not_find'
>> label.
>
> Don't include random extra stuff in patches unless there is substantial
> overlap, send one change per patch.
I submitted v2 with the unrelated changes moved to a separate patch:
https://lore.kernel.org/all/20230824211241.388201-1-cristian.ciocaltea@collabora.com/
Thanks,
Cristian
Powered by blists - more mailing lists