linux-kernel - Re: [PATCH 10/22] x86/srso: Print mitigation for retbleed IBPB case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230824214052.v2sxidqqdfounkrw@treble>
Date:   Thu, 24 Aug 2023 14:40:52 -0700
From:   Josh Poimboeuf <jpoimboe@...nel.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Babu Moger <babu.moger@....com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>, David.Kaplan@....com,
        Andrew Cooper <andrew.cooper3@...rix.com>,
        Nikolay Borisov <nik.borisov@...e.com>,
        gregkh@...uxfoundation.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 10/22] x86/srso: Print mitigation for retbleed IBPB case

On Thu, Aug 24, 2023 at 06:48:18AM +0200, Borislav Petkov wrote:
> On Sun, Aug 20, 2023 at 06:19:07PM -0700, Josh Poimboeuf wrote:
> > When overriding the requested mitigation with IBPB due to retbleed=ibpb,
> > print the actual mitigation.
> > 
> > Signed-off-by: Josh Poimboeuf <jpoimboe@...nel.org>
> > ---
> >  arch/x86/kernel/cpu/bugs.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c
> > index da480c089739..4e332707a343 100644
> > --- a/arch/x86/kernel/cpu/bugs.c
> > +++ b/arch/x86/kernel/cpu/bugs.c
> > @@ -2427,7 +2427,7 @@ static void __init srso_select_mitigation(void)
> >  		if (has_microcode) {
> >  			pr_info("Retbleed IBPB mitigation enabled, using same for SRSO\n");
> 
> This print was supposed to do that. Now you have two for the IBPB case.
> If you want to print it using the usual format, then whack the above.

Sure, and in that case I'll just drop the other one which changes the
above from pr_err() to pr_info().

-- 
Josh