linux-kernel - Re: [PATCH v2] ext4: do not mark inode dirty every time in delalloc append write scenario

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169285281339.4146427.13867368474882584364.b4-ty@mit.edu>
Date:   Thu, 24 Aug 2023 00:53:42 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     adilger.kernel@...ger.ca, jack@...e.cz,
        Liu Song <liusong@...ux.alibaba.com>
Cc:     "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, joseph.qi@...ux.alibaba.com
Subject: Re: [PATCH v2] ext4: do not mark inode dirty every time in delalloc append write scenario


On Thu, 10 Aug 2023 23:43:33 +0800, Liu Song wrote:
> In the delalloc append write scenario, if inode's i_size is extended due
> to buffer write, there are delalloc writes pending in the range up to
> i_size, and no need to touch i_disksize since writeback will push
> i_disksize up to i_size eventually. Offers significant performance
> improvement in high-frequency append write scenarios.
> 
> I conducted tests in my 32-core environment by launching 32 concurrent
> threads to append write to the same file. Each write operation had a
> length of 1024 bytes and was repeated 100000 times. Without using this
> patch, the test was completed in 7705 ms. However, with this patch, the
> test was completed in 5066 ms, resulting in a performance improvement of
> 34%.
> 
> [...]

Applied, thanks!

[1/1] ext4: do not mark inode dirty every time in delalloc append write scenario
      commit: 40b14c55e3d0496c5db7dd60b90a5c30933ac033

Best regards,
-- 
Theodore Ts'o <tytso@....edu>