[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b6d0664c-02b8-5641-c9af-218cd7bd0898@quicinc.com>
Date: Thu, 24 Aug 2023 10:54:25 +0530
From: Devi Priya <quic_devipriy@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
<agross@...nel.org>, <andersson@...nel.org>,
<konrad.dybcio@...aro.org>, <mturquette@...libre.com>,
<sboyd@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<catalin.marinas@....com>, <will@...nel.org>,
<p.zabel@...gutronix.de>, <richardcochran@...il.com>,
<arnd@...db.de>, <geert+renesas@...der.be>,
<neil.armstrong@...aro.org>, <nfraprado@...labora.com>,
<rafal@...ecki.pl>, <linux-arm-msm@...r.kernel.org>,
<linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>
CC: <quic_saahtoma@...cinc.com>
Subject: Re: [PATCH 2/6] clk: qcom: gcc-ipq9574: Mark nssnoc clocks as
critical
On 7/11/2023 3:55 PM, Dmitry Baryshkov wrote:
> On 11/07/2023 12:35, Devi Priya wrote:
>> Mark nssnoc clocks as critical as they are to be turned on to access
>> nss port tx/rx clocks.
>
> Can you please clarify, if these are turned off, one can not access
> nsscc clocks? Then the nsscc should be the consumer of these clocks
> (instead of declaring them as critical). May be using pm_clk for nsscc
> will work. If not, you'll have to do that manually from
> runtime_suspend/runtime_resume callbacks.
Sure, will use pm_clk for nsscc in V2
Thanks,
Devi Priya
>
>>
>> Signed-off-by: Devi Priya <quic_devipriy@...cinc.com>
>> ---
>> drivers/clk/qcom/gcc-ipq9574.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/clk/qcom/gcc-ipq9574.c
>> b/drivers/clk/qcom/gcc-ipq9574.c
>> index 6914f962c893..b68addc6f687 100644
>> --- a/drivers/clk/qcom/gcc-ipq9574.c
>> +++ b/drivers/clk/qcom/gcc-ipq9574.c
>> @@ -2166,7 +2166,7 @@ static struct clk_branch gcc_nssnoc_nsscc_clk = {
>> &pcnoc_bfdcd_clk_src.clkr.hw
>> },
>> .num_parents = 1,
>> - .flags = CLK_SET_RATE_PARENT,
>> + .flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
>> .ops = &clk_branch2_ops,
>> },
>> },
>> @@ -2565,7 +2565,7 @@ static struct clk_branch gcc_nssnoc_snoc_clk = {
>> &system_noc_bfdcd_clk_src.clkr.hw
>> },
>> .num_parents = 1,
>> - .flags = CLK_SET_RATE_PARENT,
>> + .flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
>> .ops = &clk_branch2_ops,
>> },
>> },
>> @@ -2582,7 +2582,7 @@ static struct clk_branch gcc_nssnoc_snoc_1_clk = {
>> &system_noc_bfdcd_clk_src.clkr.hw
>> },
>> .num_parents = 1,
>> - .flags = CLK_SET_RATE_PARENT,
>> + .flags = CLK_SET_RATE_PARENT | CLK_IS_CRITICAL,
>> .ops = &clk_branch2_ops,
>> },
>> },
>
Powered by blists - more mailing lists