[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <144fd7ac-154f-79b9-5483-56b15941f62f@bytedance.com>
Date: Thu, 24 Aug 2023 14:24:16 +0800
From: Qi Zheng <zhengqi.arch@...edance.com>
To: Juergen Gross <jgross@...e.com>
Cc: akpm@...ux-foundation.org, david@...morbit.com, tkhai@...ru,
vbabka@...e.cz, roman.gushchin@...ux.dev, djwong@...nel.org,
brauner@...nel.org, paulmck@...nel.org, tytso@....edu,
steven.price@....com, cel@...nel.org, senozhatsky@...omium.org,
yujie.liu@...el.com, gregkh@...uxfoundation.org,
muchun.song@...ux.dev, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
Muchun Song <songmuchun@...edance.com>,
Stefano Stabellini <sstabellini@...nel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>,
xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v5 05/45] xenbus/backend: dynamically allocate the
xen-backend shrinker
Hi Juergen,
On 2023/8/24 14:00, Juergen Gross wrote:
> On 24.08.23 05:42, Qi Zheng wrote:
>> Use new APIs to dynamically allocate the xen-backend shrinker.
>>
>> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>
>> Reviewed-by: Muchun Song <songmuchun@...edance.com>
>> CC: Juergen Gross <jgross@...e.com>
>> CC: Stefano Stabellini <sstabellini@...nel.org>
>> CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
>> CC: xen-devel@...ts.xenproject.org
>
> Acked-by: Juergen Gross <jgross@...e.com>
Thanks for your review!
>
> Just one note: it seems as if most users will set seeks to DEFAULT_SEEKS.
> Wouldn't it be better to do this in shrinker_alloc() and let only callers
> who want a different value overwrite that?
I think it makes sense, will do.
Thanks,
Qi
>
>
> Juergen
Powered by blists - more mailing lists