linux-kernel - Re: [PATCH v6] i2c: designware: Add support for recovery when GPIO need pinctrl.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <686d5609-7e3d-4385-a23b-f7dec13c02bf@linux.intel.com>
Date:   Thu, 24 Aug 2023 09:52:57 +0300
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Yann Sionneau <ysionneau@...ray.eu>
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Julian Vetter <jvetter@...rayinc.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andi Shyti <andi.shyti@...nel.org>
Subject: Re: [PATCH v6] i2c: designware: Add support for recovery when GPIO
 need pinctrl.

On 8/22/23 17:43, Andy Shevchenko wrote:
> On Tue, Aug 22, 2023 at 04:34:37PM +0200, Yann Sionneau wrote:
>> Currently if the SoC needs pinctrl to switch the SCL and SDA from the I2C
>> function to GPIO function, the recovery won't work.
>>
>> scl-gpio = <>;
>> sda-gpio = <>;
>>
>> Are not enough for some SoCs to have a working recovery.
>> Some need:
>>
>> scl-gpio = <>;
>> sda-gpio = <>;
>> pinctrl-names = "default", "recovery";
>> pinctrl-0 = <&i2c_pins_hw>;
>> pinctrl-1 = <&i2c_pins_gpio>;
>>
>> The driver was not filling rinfo->pinctrl with the device node
>> pinctrl data which is needed by generic recovery code.
> 
> Now looks pretty much good enough (yet the period is not needed in the Subject,
> but it's fine for your newbie submission — no need to resend or make a new
> version). Thank you!
> 
Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>